[Mesa-dev] [PATCH] autoconf: Make header install distinct for various APIs

Chuck Atkins chuck.atkins at kitware.com
Tue Oct 4 14:17:38 UTC 2016


>
> > +eglinterop_HEADERS = $(top_srcdir)/include/GL/mesa_glinterop.h
> IIRC Marek was pretty clear that this header should not be installed.
> Then again looking at our current wildcard installing ... seems like
> it was.
>
> Please drop this file from the install stage ?
>

Dropped.


> +if HAVE_COMMON_OSMESA
> > +osmesadir = $(includedir)/GL
> > +osmesa_HEADERS = $(top_srcdir)/include/GL/osmesa.h
> > +endif
> > +
> Why do we have this hunk, considering each target is handled explicitly ?
>
> IMHO we should drop either this or the similar ones in
> src/{mesa,gallium}/Makefile.am. The latter might be better ?
>

The idea was to seperate the interface install from the implementation
build in the same way that it's done for GLX.  Mostly to reduce code
duplication.  At the top level the interface headers are installed then at
the deeper nested level the chosen implementation is built.  It does,
however, look like I forgot to drop the header install from the
implementations.  Will do.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161004/2ba0215b/attachment.html>


More information about the mesa-dev mailing list