[Mesa-dev] [PATCH v2 3/4] intel/blorp: Emit 3DSTATE_STENCIL_BUFFER before HIER_DEPTH

Jason Ekstrand jason at jlekstrand.net
Sat Apr 8 05:42:24 UTC 2017


We're about to replace blorp's emit code with ISL and it emits them in
the other order.  This makes diffing the aubs easier.
---
 src/intel/blorp/blorp_genX_exec.h | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/intel/blorp/blorp_genX_exec.h b/src/intel/blorp/blorp_genX_exec.h
index 3791462..9532e89 100644
--- a/src/intel/blorp/blorp_genX_exec.h
+++ b/src/intel/blorp/blorp_genX_exec.h
@@ -854,18 +854,6 @@ blorp_emit_depth_stencil_config(struct blorp_batch *batch,
       }
    }
 
-   blorp_emit(batch, GENX(3DSTATE_HIER_DEPTH_BUFFER), hiz) {
-      if (params->depth.aux_usage == ISL_AUX_USAGE_HIZ) {
-         hiz.SurfacePitch = params->depth.aux_surf.row_pitch - 1;
-         hiz.SurfaceBaseAddress = params->depth.aux_addr;
-         hiz.HierarchicalDepthBufferMOCS = mocs;
-#if GEN_GEN >= 8
-         hiz.SurfaceQPitch =
-            isl_surf_get_array_pitch_sa_rows(&params->depth.aux_surf) >> 2;
-#endif
-      }
-   }
-
    blorp_emit(batch, GENX(3DSTATE_STENCIL_BUFFER), sb) {
       if (params->stencil.enabled) {
 #if GEN_GEN >= 8 || GEN_IS_HASWELL
@@ -883,6 +871,18 @@ blorp_emit_depth_stencil_config(struct blorp_batch *batch,
       }
    }
 
+   blorp_emit(batch, GENX(3DSTATE_HIER_DEPTH_BUFFER), hiz) {
+      if (params->depth.aux_usage == ISL_AUX_USAGE_HIZ) {
+         hiz.SurfacePitch = params->depth.aux_surf.row_pitch - 1;
+         hiz.SurfaceBaseAddress = params->depth.aux_addr;
+         hiz.HierarchicalDepthBufferMOCS = mocs;
+#if GEN_GEN >= 8
+         hiz.SurfaceQPitch =
+            isl_surf_get_array_pitch_sa_rows(&params->depth.aux_surf) >> 2;
+#endif
+      }
+   }
+
    /* 3DSTATE_CLEAR_PARAMS
     *
     * From the Sandybridge PRM, Volume 2, Part 1, Section 3DSTATE_CLEAR_PARAMS:
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list