[Mesa-dev] [PATCH 11/15] llvmpipe: remove unused subpixel_snap() and fixed_to_float()

Roland Scheidegger sroland at vmware.com
Tue Apr 11 18:31:09 UTC 2017


subpixel_snap is very much used (fixed_to_float, not so much), so you
can't get rid of it.
If you want you can place it into a #if !defined(PIPE_ARCH_SSE) clause
though...

Roland

Am 11.04.2017 um 19:58 schrieb Samuel Pitoiset:
> Fixes the following Clang warnings.
> 
> lp_setup_tri.c:55:1: warning: unused function 'subpixel_snap' [-Wunused-function]
> subpixel_snap(float a)
> ^
> lp_setup_tri.c:61:1: warning: unused function 'fixed_to_float' [-Wunused-function]
> fixed_to_float(int a)
> ^
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/llvmpipe/lp_setup_tri.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_setup_tri.c b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> index 98243a12de..cc1508ccc2 100644
> --- a/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> +++ b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> @@ -51,18 +51,6 @@
>  #include "util/u_pwr8.h"
>  #endif
>  
> -static inline int
> -subpixel_snap(float a)
> -{
> -   return util_iround(FIXED_ONE * a);
> -}
> -
> -static inline float
> -fixed_to_float(int a)
> -{
> -   return a * (1.0f / FIXED_ONE);
> -}
> -
>  
>  /* Position and area in fixed point coordinates */
>  struct fixed_position {
> 



More information about the mesa-dev mailing list