[Mesa-dev] [PATCH 1/2] Update TextureParameter* error for incompatible texture targets

[Jordan Justen]

On 2017-08-06 21:18:23, Iago Toral Quiroga wrote:
> The OpenGL 4.6 specs have been updated so that GetTextureParameter*
> with a texture object with an incompatible TEXTURE_TARGET should now
> report INVALID_OPERATION instead of INVALID_ENUM.
> 
> Fixes:
> KHR-GL45.direct_state_access.textures_parameter_errors

Assuming there is no regression with the GLES CTS, both patches:

Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

> ---
>  src/mesa/main/texparam.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c
> index b6e91503ea..039b93349e 100644
> --- a/src/mesa/main/texparam.c
> +++ b/src/mesa/main/texparam.c
> @@ -174,7 +174,7 @@ get_texobj_by_name(struct gl_context *ctx, GLuint texture, const char *name)
>     case GL_TEXTURE_RECTANGLE:
>        return texObj;
>     default:
> -      _mesa_error(ctx, GL_INVALID_ENUM, "%s(target)", name);
> +      _mesa_error(ctx, GL_INVALID_OPERATION, "%s(target)", name);
>        return NULL;
>     }
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev