[Mesa-dev] [PATCH 00/16] anv/i965: Cleanup copies of devinfo fields in brw_context

[Lionel Landwerlin]

On 30/08/17 11:30, Samuel Iglesias Gonsálvez wrote:
> On Wed, 2017-08-30 at 11:10 +0100, Lionel Landwerlin wrote:
>> You can find this series on github :
>> https://github.com/djdeath/mesa/tree/wip/djdeath/drop-is-has-brw
>>
>> (One paches got caught by the mailing list's size limit)
>>
> Assuming there is no regressions on Intel CI, series is:
>
> Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

Yep, it's clean.
Thanks for the review!

>
> Sam
>
>> On 30/08/17 11:07, Lionel Landwerlin wrote:
>>> Hi all,
>>>
>>> Following a quick discussion on IRC, Matt reminded me we still had
>>> some duplicated fields on brw_context which just hold the same
>>> values
>>> as gen_device_info. Let's just use gen_device_info instead.
>>>
>>> Cheers,
>>>
>>> Lionel Landwerlin (16):
>>>     anv: use device->info instead of brw->is_*
>>>     i965: drop brw->gen in favor of devinfo->gen
>>>     i965: drop brw->gt in favor of devinfo->gt
>>>     i965: drop brw->is_g4x in favor of devinfo->is_g4x
>>>     i965: drop brw->is_baytrail in favor of devinfo->is_baytrail
>>>     i965: drop brw->is_haswell in favor of devinfo->is_haswell
>>>     i965: drop brw->is_cherryview in favor of devinfo->is_cherryview
>>>     i965: drop brw->is_broxton
>>>     i965: drop brw->has_llc in favor of devinfo->has_llc
>>>     i965: drop unused brw->has_compr4
>>>     i965: drop unused brw->has_negative_rhw_bug
>>>     i965: drop brw->must_use_separate_stencil in favor of devinfo's
>>>     i965: drop unused brw->has_pln
>>>     i965: drop unused brw->no_simd8
>>>     i965: drop brw->has_surface_tile_offset in favor of devinfo's
>>>     i965: drop unused brw->needs_unlit_centroid_workaround
>>>
>>>    src/intel/vulkan/genX_pipeline.c                  |  2 +-
>>>    src/mesa/drivers/dri/i965/brw_binding_tables.c    |  6 +-
>>>    src/mesa/drivers/dri/i965/brw_blorp.c             | 30 +++++---
>>>    src/mesa/drivers/dri/i965/brw_clear.c             |  8 +-
>>>    src/mesa/drivers/dri/i965/brw_clip.c              |  3 +-
>>>    src/mesa/drivers/dri/i965/brw_compute.c           | 14 ++--
>>>    src/mesa/drivers/dri/i965/brw_context.c           | 86
>>> ++++++++++------------
>>>    src/mesa/drivers/dri/i965/brw_context.h           | 25 -------
>>>    src/mesa/drivers/dri/i965/brw_cs.c                |  2 +-
>>>    src/mesa/drivers/dri/i965/brw_curbe.c             |  4 +-
>>>    src/mesa/drivers/dri/i965/brw_draw.c              | 22 +++---
>>>    src/mesa/drivers/dri/i965/brw_draw_upload.c       | 22 +++---
>>>    src/mesa/drivers/dri/i965/brw_ff_gs.c             |  8 +-
>>>    src/mesa/drivers/dri/i965/brw_formatquery.c       |  5 +-
>>>    src/mesa/drivers/dri/i965/brw_gs.c                |  3 +-
>>>    src/mesa/drivers/dri/i965/brw_link.cpp            |  9 ++-
>>>    src/mesa/drivers/dri/i965/brw_meta_util.c         |  7 +-
>>>    src/mesa/drivers/dri/i965/brw_misc_state.c        | 66
>>> ++++++++++-------
>>>    src/mesa/drivers/dri/i965/brw_pipe_control.c      | 46 ++++++++
>>> ----
>>>    src/mesa/drivers/dri/i965/brw_primitive_restart.c |  3 +-
>>>    src/mesa/drivers/dri/i965/brw_program.c           | 11 ++-
>>>    src/mesa/drivers/dri/i965/brw_queryobj.c          | 29 +++++---
>>>    src/mesa/drivers/dri/i965/brw_state_upload.c      | 39 +++++-----
>>>    src/mesa/drivers/dri/i965/brw_surface_formats.c   |  9 ++-
>>>    src/mesa/drivers/dri/i965/brw_tcs.c               | 10 ++-
>>>    src/mesa/drivers/dri/i965/brw_urb.c               |  6 +-
>>>    src/mesa/drivers/dri/i965/brw_vs.c                |  8 +-
>>>    src/mesa/drivers/dri/i965/brw_wm.c                | 37 +++++-----
>>>    src/mesa/drivers/dri/i965/brw_wm_surface_state.c  | 54 +++++++++-
>>> ----
>>>    src/mesa/drivers/dri/i965/gen6_constant_state.c   |  3 +-
>>>    src/mesa/drivers/dri/i965/gen6_queryobj.c         | 18 +++--
>>>    src/mesa/drivers/dri/i965/gen6_sol.c              |  6 +-
>>>    src/mesa/drivers/dri/i965/gen7_l3_state.c         | 11 +--
>>>    src/mesa/drivers/dri/i965/gen7_misc_state.c       |  3 +-
>>>    src/mesa/drivers/dri/i965/gen7_sol_state.c        |  9 ++-
>>>    src/mesa/drivers/dri/i965/gen7_urb.c              | 13 ++--
>>>    src/mesa/drivers/dri/i965/gen8_depth_state.c      |  9 ++-
>>>    src/mesa/drivers/dri/i965/genX_state_upload.c     | 12 ++-
>>>    src/mesa/drivers/dri/i965/hsw_queryobj.c          | 10 ++-
>>>    src/mesa/drivers/dri/i965/hsw_sol.c               |  9 ++-
>>>    src/mesa/drivers/dri/i965/intel_batchbuffer.c     | 69
>>> ++++++++++++------
>>>    src/mesa/drivers/dri/i965/intel_blit.c            | 31 +++++---
>>>    src/mesa/drivers/dri/i965/intel_copy_image.c      |  4 +-
>>>    src/mesa/drivers/dri/i965/intel_extensions.c      | 37 +++++-----
>>>    src/mesa/drivers/dri/i965/intel_fbo.c             | 17 +++--
>>>    src/mesa/drivers/dri/i965/intel_mipmap_tree.c     | 89
>>> +++++++++++++++--------
>>>    src/mesa/drivers/dri/i965/intel_pixel_read.c      |  5 +-
>>>    src/mesa/drivers/dri/i965/intel_tex.c             |  3 +-
>>>    src/mesa/drivers/dri/i965/intel_tex_image.c       | 10 ++-
>>>    src/mesa/drivers/dri/i965/intel_tex_subimage.c    |  5 +-
>>>    src/mesa/drivers/dri/i965/intel_tex_validate.c    |  3 +-
>>>    51 files changed, 561 insertions(+), 389 deletions(-)
>>>
>>> --
>>> 2.14.1
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev