[Mesa-dev] [PATCH 6/7] radv: change the needs_push_constants logic

Samuel Pitoiset samuel.pitoiset at gmail.com
Mon Dec 18 18:38:57 UTC 2017


Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/common/ac_shader_info.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c
index 4df428ae81..6aadb5032e 100644
--- a/src/amd/common/ac_shader_info.c
+++ b/src/amd/common/ac_shader_info.c
@@ -148,10 +148,10 @@ ac_nir_shader_info_pass(struct nir_shader *nir,
 {
 	struct nir_function *func = (struct nir_function *)exec_list_get_head(&nir->functions);
 
-	info->needs_push_constants = true;
-	if (!options->layout->push_constant_size &&
-	    !options->layout->dynamic_offset_count)
-		info->needs_push_constants = false;
+	info->needs_push_constants = false;
+	if (options->layout->push_constant_size ||
+	    options->layout->dynamic_offset_count)
+		info->needs_push_constants = true;
 
 	nir_foreach_variable(variable, &nir->inputs)
 		gather_info_input_decl(nir, options, variable, info);
-- 
2.15.1



More information about the mesa-dev mailing list