[Mesa-dev] [PATCH 2/2] radeonsi: don't do cmask fast clears on gfx9 single sample

Marek Olšák maraeo at gmail.com
Wed Dec 27 21:19:21 UTC 2017


CMASK fast clears work on gfx9 just fine. I can't accept this patch.

Marek

On Wed, Dec 27, 2017 at 1:44 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> AMDVLK says that these don't work, so disable them.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/gallium/drivers/radeonsi/si_clear.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c
> index ba95ed51f1..2b2ac79908 100644
> --- a/src/gallium/drivers/radeonsi/si_clear.c
> +++ b/src/gallium/drivers/radeonsi/si_clear.c
> @@ -480,7 +480,11 @@ static void si_do_fast_color_clear(struct si_context *sctx,
>                                 continue;
>                         }
>
> -                       /* RB+ doesn't work with CMASK fast clear on Stoney. */
> +                       /* amdvlk doesn't enable cmask fast clears on single sample */
> +                       if (sctx->b.chip_class >= GFX9 && tex->resource.b.b.nr_samples <= 1)
> +                               continue;
> +
> +                       /* RB+ doesn't work with CMASK fast clear on Stoney */
>                         if (sctx->b.family == CHIP_STONEY)
>                                 continue;
>
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list