[Mesa-dev] [PATCH mesa 2/2] etnaviv: fix boolean test

[Christian Gmeiner]

Hi Eric

2017-02-09 1:11 GMT+01:00 Eric Engestrom <eric at engestrom.ch>:
> CID: 1400128
> Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> ---
>  src/gallium/drivers/etnaviv/etnaviv_screen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> index 8f2882f573..e398629a42 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> @@ -578,7 +578,7 @@ etna_get_specs(struct etna_screen *screen)
>        DBG("could not get ETNA_GPU_PIXEL_PIPES");
>        goto fail;
>     }
> -   if (val < 1 && val > ETNA_MAX_PIXELPIPES) {
> +   if (val < 1 || val > ETNA_MAX_PIXELPIPES) {
>        if (val == 0) {
>           fprintf(stderr, "Warning: zero pixel pipes (update kernel?)\n");
>           val = 1;
> --
> Cheers,
>   Eric
>

That change looks good ti me. I think I will take your patch and
rework my 'remove number of pixel pipes validation'
patch based on your change.

greets
--
Christian Gmeiner, MSc

https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner