[Mesa-dev] [PATCH] egl/wayland: resolve quirky try_damage_buffer() implementation

[Daniel Stone]

Hi Emil,

On 13 January 2017 at 17:27, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> The implementation was added with commit d085a5dff5b and effectively
> provided a hidden dependency.
>
> Namely: the codepath used was determined solely during build time. Thus
> if we built again new wayland and then run against older (yet still
> within the requirements, as per the configure) one will get undefined
> symbols.
>
> As of earlier commit 36b9976e1f9 "egl/wayland: Avoid race conditions
> when on non-main thread" the required version was bumped to one which
> provides the API, thus we can drop the quirky solution.

Works for me:
Reviewed-by: Daniel Stone <daniels at collabora.com>

> One way to avoid the issue w/o bumping the requirement (for -stable) is
> to add fall-back define alongside weak implementation of the functions.
> The latter should "return false" and will get automatically overridden
> if new enough wayland is used.
>
> Not sure how much one should care - just thinking out loud.

On the other hand, I'm more than happy to leave the runtime-resolution
and stable branch details to you!

Cheers,
Daniel