[Mesa-dev] [PATCH] radv: add back ability to gen some entrypoints from optional headers (v2)

[Emil Velikov]

On 24 January 2017 at 01:17, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> bf8e1f9e7 radv: generate entrypoints from vk.xml
> ripped out the ability to add extra header files (and writing
> extra xml files is a bit messier). For some non-public
> development or even developing future EXT/MESA extensions,
> it would be nice to allow this option before things land in
> the registry.
>
> This reintroduces this functionality on top of the registry.
>
> I think anv might also be interested in having this work.
>
> v2: add back include files which I think install needs.
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/Makefile.am             | 14 +++++++-----
>  src/amd/vulkan/radv_entrypoints_gen.py | 39 ++++++++++++++++++++++++++++++++--
>  2 files changed, 46 insertions(+), 7 deletions(-)
>
> diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am
> index b47109b..a25c5b8 100644
> --- a/src/amd/vulkan/Makefile.am
> +++ b/src/amd/vulkan/Makefile.am
> @@ -23,10 +23,14 @@ include Makefile.sources
>
>  vulkan_includedir = $(includedir)/vulkan
>
> -vulkan_include_HEADERS = \
> +vulkan_include_HEADERS =
If you're keen on not installing the headers please keep that as
separate commit. Please keep this hunk as-is

>         $(top_srcdir)/include/vulkan/vk_platform.h \
>         $(top_srcdir)/include/vulkan/vulkan.h
>
> +# Unused in-tree but used for out of tree development (KHR internal or otherwise)
> +vulkan_extra_includedir = $(includedir)/vulkan
Afaict you don't need to install any internal or otherwise headers, right ?

> +vulkan_extra_include_HEADERS =
> +
... thus this can become noinst_HEADERS and one can update the references below.

Thanks
Emil