[Mesa-dev] [PATCH 13/25] gallium: introduce PIPE_CAP_MEMOBJ

Andres Rodriguez andresx7 at gmail.com
Fri Jul 7 18:14:46 UTC 2017


Thanks Ilia, I'll get that fixed up.

Regards,
Andres

On 2017-07-07 09:53 AM, Ilia Mirkin wrote:
> This is missing the docs addition for what this cap does
> (gallium/docs/source/screen.rst).
> 
> On Fri, Jul 7, 2017 at 12:24 AM, Andres Rodriguez <andresx7 at gmail.com> wrote:
>> This can be used to guard support for EXT_memory_object and related
>> extensions.
>>
>> Signed-off-by: Andres Rodriguez <andresx7 at gmail.com>
>> ---
>>   src/gallium/drivers/etnaviv/etnaviv_screen.c     | 1 +
>>   src/gallium/drivers/freedreno/freedreno_screen.c | 1 +
>>   src/gallium/drivers/i915/i915_screen.c           | 1 +
>>   src/gallium/drivers/llvmpipe/lp_screen.c         | 1 +
>>   src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 1 +
>>   src/gallium/drivers/nouveau/nvc0/nvc0_screen.c   | 1 +
>>   src/gallium/drivers/r300/r300_screen.c           | 1 +
>>   src/gallium/drivers/r600/r600_pipe.c             | 1 +
>>   src/gallium/drivers/radeonsi/si_pipe.c           | 1 +
>>   src/gallium/drivers/softpipe/sp_screen.c         | 1 +
>>   src/gallium/drivers/svga/svga_screen.c           | 1 +
>>   src/gallium/drivers/swr/swr_screen.cpp           | 1 +
>>   src/gallium/drivers/vc4/vc4_screen.c             | 1 +
>>   src/gallium/drivers/virgl/virgl_screen.c         | 1 +
>>   src/gallium/include/pipe/p_defines.h             | 1 +
>>   15 files changed, 15 insertions(+)
>>
>> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c
>> index eefb51c..718f0ac 100644
>> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
>> +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
>> @@ -258,6 +258,7 @@ etna_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>      case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>      case PIPE_CAP_POST_DEPTH_COVERAGE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>
>>      /* Stream output. */
>> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
>> index a915d65..6c9c011 100644
>> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
>> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
>> @@ -321,6 +321,7 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>          case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>          case PIPE_CAP_POST_DEPTH_COVERAGE:
>>          case PIPE_CAP_BINDLESS_TEXTURE:
>> +       case PIPE_CAP_MEMOBJ:
>>                  return 0;
>>
>>          case PIPE_CAP_MAX_VIEWPORTS:
>> diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c
>> index 4ad98e2..3919978 100644
>> --- a/src/gallium/drivers/i915/i915_screen.c
>> +++ b/src/gallium/drivers/i915/i915_screen.c
>> @@ -310,6 +310,7 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
>>      case PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX:
>>      case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>
>>      case PIPE_CAP_MAX_VIEWPORTS:
>> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
>> index e98e30d..7959015 100644
>> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
>> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
>> @@ -356,6 +356,7 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>      case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>      case PIPE_CAP_POST_DEPTH_COVERAGE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>      }
>>      /* should only get here on unhandled cases */
>> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
>> index a352ff5..14d1b1a 100644
>> --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
>> +++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
>> @@ -220,6 +220,7 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>      case PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX:
>>      case PIPE_CAP_POST_DEPTH_COVERAGE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>
>>      case PIPE_CAP_VENDOR_ID:
>> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> index 8bbe403..571df1c 100644
>> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> @@ -301,6 +301,7 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>      case PIPE_CAP_INT64_DIVMOD:
>>      case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>
>>      case PIPE_CAP_VENDOR_ID:
>> diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c
>> index 5cdb248..37d102b 100644
>> --- a/src/gallium/drivers/r300/r300_screen.c
>> +++ b/src/gallium/drivers/r300/r300_screen.c
>> @@ -242,6 +242,7 @@ static int r300_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>>           case PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX:
>>           case PIPE_CAP_POST_DEPTH_COVERAGE:
>>           case PIPE_CAP_BINDLESS_TEXTURE:
>> +        case PIPE_CAP_MEMOBJ:
>>               return 0;
>>
>>           /* SWTCL-only features. */
>> diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
>> index f0ea409..e3abc10 100644
>> --- a/src/gallium/drivers/r600/r600_pipe.c
>> +++ b/src/gallium/drivers/r600/r600_pipe.c
>> @@ -398,6 +398,7 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>>          case PIPE_CAP_TGSI_TES_LAYER_VIEWPORT:
>>          case PIPE_CAP_POST_DEPTH_COVERAGE:
>>          case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>                  return 0;
>>
>>          case PIPE_CAP_DOUBLES:
>> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
>> index 5f3b7e1..bc0e38f 100644
>> --- a/src/gallium/drivers/radeonsi/si_pipe.c
>> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
>> @@ -593,6 +593,7 @@ static int si_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>>          case PIPE_CAP_UMA:
>>          case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
>>          case PIPE_CAP_POST_DEPTH_COVERAGE:
>> +       case PIPE_CAP_MEMOBJ:
>>                  return 0;
>>
>>          case PIPE_CAP_QUERY_BUFFER_OBJECT:
>> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
>> index 5c96a14..bfcb22b 100644
>> --- a/src/gallium/drivers/softpipe/sp_screen.c
>> +++ b/src/gallium/drivers/softpipe/sp_screen.c
>> @@ -306,6 +306,7 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>      case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>      case PIPE_CAP_POST_DEPTH_COVERAGE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>      case PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT:
>>         return 4;
>> diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c
>> index 0b63525..c7e11e3 100644
>> --- a/src/gallium/drivers/svga/svga_screen.c
>> +++ b/src/gallium/drivers/svga/svga_screen.c
>> @@ -445,6 +445,7 @@ svga_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>      case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>      case PIPE_CAP_POST_DEPTH_COVERAGE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>      }
>>
>> diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp
>> index 53b5dad..8f008ec 100644
>> --- a/src/gallium/drivers/swr/swr_screen.cpp
>> +++ b/src/gallium/drivers/swr/swr_screen.cpp
>> @@ -341,6 +341,7 @@ swr_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>      case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>      case PIPE_CAP_POST_DEPTH_COVERAGE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>
>>      case PIPE_CAP_VENDOR_ID:
>> diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c
>> index cbeb683..fbeec5b 100644
>> --- a/src/gallium/drivers/vc4/vc4_screen.c
>> +++ b/src/gallium/drivers/vc4/vc4_screen.c
>> @@ -258,6 +258,7 @@ vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>>          case PIPE_CAP_CAN_BIND_CONST_BUFFER_AS_VERTEX:
>>           case PIPE_CAP_POST_DEPTH_COVERAGE:
>>           case PIPE_CAP_BINDLESS_TEXTURE:
>> +        case PIPE_CAP_MEMOBJ:
>>                   return 0;
>>
>>                   /* Stream output. */
>> diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c
>> index 5df0840..a46e58a 100644
>> --- a/src/gallium/drivers/virgl/virgl_screen.c
>> +++ b/src/gallium/drivers/virgl/virgl_screen.c
>> @@ -265,6 +265,7 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap param)
>>      case PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION:
>>      case PIPE_CAP_POST_DEPTH_COVERAGE:
>>      case PIPE_CAP_BINDLESS_TEXTURE:
>> +   case PIPE_CAP_MEMOBJ:
>>         return 0;
>>      case PIPE_CAP_VENDOR_ID:
>>         return 0x1af4;
>> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
>> index 2ccdf44..91efa65 100644
>> --- a/src/gallium/include/pipe/p_defines.h
>> +++ b/src/gallium/include/pipe/p_defines.h
>> @@ -780,6 +780,7 @@ enum pipe_cap
>>      PIPE_CAP_ALLOW_MAPPED_BUFFERS_DURING_EXECUTION,
>>      PIPE_CAP_POST_DEPTH_COVERAGE,
>>      PIPE_CAP_BINDLESS_TEXTURE,
>> +   PIPE_CAP_MEMOBJ,
>>   };
>>
>>   #define PIPE_QUIRK_TEXTURE_BORDER_COLOR_SWIZZLE_NV50 (1 << 0)
>> --
>> 2.9.3
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list