[Mesa-dev] [PATCH mesa 0/5] egl/wayland: Make wl_egl_window a versioned struct

Daniel Stone daniel at fooishbar.org
Fri Jul 21 13:37:56 UTC 2017


Hi Miguel,

On 18 July 2017 at 21:49, Miguel A. Vico <mvicomoya at nvidia.com> wrote:
> Although we've always made backwards compatible changes to wl_egl_window, we
> are lacking of a versioning mechanism for EGL drivers that take a native
> wl_egl_window to check what set of features are exposed/available by the given
> struct.
>
> This series of patches aim to make wl_egl_window a versioned struct in a
> backwards compatible way.
>
> Along the way, a wl_egl_window ABI checker program has been added that runs
> at 'make check' time.
>
> Also, _eglPointerIsDereferencable() is fixed to return whether is
> dereferencable, regardless of memory residency.

Thanks for doing this. I do have a weak preference for this being in
libwayland - given that we're effectively declaring this
implementation to be part of the wayland-egl ABI with this patchset -
but I can see it would be annoying to migrate the implementation
between patches. *shrug*

Ack either way from me.

Cheers,
Daniel


More information about the mesa-dev mailing list