[Mesa-dev] [PATCH 2/3] i965: Fix = vs == in MCS aux usage assert.

Jason Ekstrand jason at jlekstrand.net
Wed Jul 26 02:12:32 UTC 2017


Oops... R-B


On July 25, 2017 11:04:22 AM Kenneth Graunke <kenneth at whitecape.org> wrote:

> Caught by Coverity (CID 1415680).
>
> Cc: "17.2" <mesa-stable at lists.freedesktop.org>
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c 
> b/src/mesa/drivers/dri/i965/brw_blorp.c
> index 36f7ed2a39d..a0f37780ef5 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.c
> @@ -1103,7 +1103,7 @@ brw_blorp_mcs_partial_resolve(struct brw_context *brw,
>     DBG("%s to mt %p layers %u-%u\n", __FUNCTION__, mt,
>         start_layer, start_layer + num_layers - 1);
>
> -   assert(mt->aux_usage = ISL_AUX_USAGE_MCS);
> +   assert(mt->aux_usage == ISL_AUX_USAGE_MCS);
>
>     const mesa_format format = _mesa_get_srgb_format_linear(mt->format);
>     enum isl_format isl_format = brw_blorp_to_isl_format(brw, format, true);
> --
> 2.13.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev




More information about the mesa-dev mailing list