[Mesa-dev] [PATCH 2/2] ac/sid.h: don't use parentheses in PKT3_RELEASE_MEM definition

Nicolai Hähnle nhaehnle at gmail.com
Mon Jun 19 11:56:49 UTC 2017


For the series:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

On 16.06.2017 14:30, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> The parses skips the line if it contains parentheses.
> ---
>   src/amd/common/sid.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h
> index c69f4f6..a8c78c1 100644
> --- a/src/amd/common/sid.h
> +++ b/src/amd/common/sid.h
> @@ -163,21 +163,21 @@
>   #define PKT3_ME_INITIALIZE                     0x44 /* not on CIK */
>   #define PKT3_COND_WRITE                        0x45
>   #define PKT3_EVENT_WRITE                       0x46
>   #define PKT3_EVENT_WRITE_EOP                   0x47 /* not on GFX9 */
>   /* CP DMA bug: Any use of CP_DMA.DST_SEL=TC must be avoided when EOS packets
>    * are used. Use DST_SEL=MC instead. For prefetch, use SRC_SEL=TC and
>    * DST_SEL=MC. Only CIK chips are affected.
>    */
>   /* fix CP DMA before uncommenting: */
>   /*#define PKT3_EVENT_WRITE_EOS                   0x48*/ /* not on GFX9 */
> -#define PKT3_RELEASE_MEM                       0x49 /* GFX9+ (any ring) or GFX8 (compute ring only) */
> +#define PKT3_RELEASE_MEM                       0x49 /* GFX9+ [any ring] or GFX8 [compute ring only] */
>   #define PKT3_ONE_REG_WRITE                     0x57 /* not on CIK */
>   #define PKT3_ACQUIRE_MEM                       0x58 /* new for CIK */
>   #define PKT3_SET_CONFIG_REG                    0x68
>   #define PKT3_SET_CONTEXT_REG                   0x69
>   #define PKT3_SET_SH_REG                        0x76
>   #define PKT3_SET_SH_REG_OFFSET                 0x77
>   #define PKT3_SET_UCONFIG_REG                   0x79 /* new for CIK */
>   #define PKT3_LOAD_CONST_RAM                    0x80
>   #define PKT3_WRITE_CONST_RAM                   0x81
>   #define PKT3_DUMP_CONST_RAM                    0x83
> 
/

-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list