[Mesa-dev] [PATCH v4 6/8] nir: Add a simple int64 lowering pass

Matt Turner mattst88 at gmail.com
Wed Mar 1 20:37:46 UTC 2017


On Sat, Feb 25, 2017 at 1:10 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> The algorithms used by this pass, especially for division, are heavily
> based on the work Ian Romanick did for the similar int64 lowering pass
> in the GLSL compiler.
>
> v2: Properly handle vectors
>
> v3: Get rid of log2_denom stuff.  Since we're using bcsel, we do all the
>     calculations anyway and this is just extra instructions.
>
> v4:
>  - Add back in the log2_denom stuff since it's needed for ensuring that
>    the shifts don't overflow.
>  - Rework the looping part of the pass to be easier to expand.


Looks like a good, straight-forward port of Ian's GLSL pass.

Reviewed-by: Matt Turner <mattst88 at gmail.com>

Looks like Samuel reviewed the rest.


More information about the mesa-dev mailing list