[Mesa-dev] [PATCH 0/6] isl: Fix requests for exact row pitch

Anuj Phogat anuj.phogat at gmail.com
Mon Mar 6 20:02:03 UTC 2017


On Mon, Mar 6, 2017 at 10:12 AM, Chad Versace <chadversary at chromium.org> wrote:
> All callers of isl_surf_init() that set 'min_row_pitch' wanted to
> request an *exact* row pitch, as evidenced by nearby asserts, but isl
> lacked API for doing so. This series fixes that by adding a field,
> isl_surf_init_info::row_pitch.
>
> This prepares for VK_MESAX_external_image_dma_buf, which requires
> support for create VkImages with an exact, user-provided row pitch.
>
> This patch series lives at:
>     git://git.kiwitree.net/~chadv/mesa
>     refs/tags/chadv/review/isl-request-exact-row-pitch-v01
>     gitweb: http://git.kiwitree.net/cgit/~chadv/mesa/tag/?h=chadv/review/isl-request-exact-row-pitch-v01
>
> Chad Versace (6):
>   isl: Fix s/pitch/row_pitch/ in comment
>   isl: Rename isl_surf_init_info::min_pitch -> min_row_pitch
>   isl: Refactor row pitch calculation
>   isl: Let isl_surf_init's caller set the exact row pitch
>   intel: Fix requests for exact surface row pitch
>   isl: Drop unused isl_surf_init_info::min_pitch
>
>  src/intel/blorp/blorp_blit.c |  3 +-
>  src/intel/isl/isl.c          | 65 +++++++++++++++++++++++++++++++-------------
>  src/intel/isl/isl.h          | 10 +++++--
>  src/intel/vulkan/anv_blorp.c |  3 +-
>  src/intel/vulkan/anv_image.c |  2 +-
>  5 files changed, 57 insertions(+), 26 deletions(-)
>
> --
> 2.12.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

LGTM. Series is:
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the mesa-dev mailing list