[Mesa-dev] [PATCH 6/6] configure.ac: Ensure libomxil-bellagio exists before invoking pkg-config.

[Emil Velikov]

On 6 March 2017 at 19:06, Matt Turner <mattst88 at gmail.com> wrote:
> I was already tired of seeing the message
>
>     Package libomxil-bellagio was not found in the pkg-config search path.
>     Perhaps you should add the directory containing `libomxil-bellagio.pc'
>     to the PKG_CONFIG_PATH environment variable
>     No package 'libomxil-bellagio' found
>
> on every configure, but I just got a distro bug reported where the user
> was confused by this message and thought it indicated a bug.
> ---
>  configure.ac | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index d483baa..8d78aa6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2195,7 +2195,8 @@ AC_ARG_WITH([omx-libdir],
>      [AS_HELP_STRING([--with-omx-libdir=DIR],
>          [directory for the OMX libraries])],
>      [OMX_LIB_INSTALL_DIR="$withval"],
> -    [OMX_LIB_INSTALL_DIR=`$PKG_CONFIG --define-variable=libdir=\$libdir --variable=pluginsdir libomxil-bellagio`])
> +    [OMX_LIB_INSTALL_DIR=`$PKG_CONFIG --define-variable=libdir=\$libdir --exists libomxil-bellagio && \
We don't need the --define-variable in the above case, do we ? With
that fixed (or with comment in the summary why we need it) the whole
series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emiil