[Mesa-dev] [PATCH] anv: change BLOCK_POOL_MEMFD_SIZE to exactly 2GB

Jason Ekstrand jason at jlekstrand.net
Tue Mar 7 15:08:02 UTC 2017


Interesting... This must only affect android for some weird reason because 
32-bit builds have been working on regular Linux for some time now.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


On March 7, 2017 1:18:25 AM Tapani Pälli <tapani.palli at intel.com> wrote:

> This is what comment above definition says and change fixes issue with
> 32bit build where BLOCK_POOL_MEMFD_SIZE is used as ftruncate parameter
> and constant currently gets converted from 4294967296 to 0.
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  src/intel/vulkan/anv_private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index c73196a..86b20c4 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -386,7 +386,7 @@ struct anv_block_pool {
>  };
>
>  /* Block pools are backed by a fixed-size 2GB memfd */
> -#define BLOCK_POOL_MEMFD_SIZE (1ull << 32)
> +#define BLOCK_POOL_MEMFD_SIZE (1ul << 31)
>
>  /* The center of the block pool is also the middle of the memfd.  This may
>   * change in the future if we decide differently for some reason.
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev




More information about the mesa-dev mailing list