[Mesa-dev] [PATCH 1/3] dri: Add an image creation with modifiers

[Emil Velikov]

Hi Ben,

On 13 March 2017 at 21:47, Ben Widawsky <ben at bwidawsk.net> wrote:
> On 17-03-10 10:28:42, Emil Velikov wrote:
>>
>> Hi Ben,
>>
>> Mostly pointing out a few things that look strange, pardon if some
>> seem too pedantic.
>>
>> On 10 March 2017 at 01:48, Ben Widawsky <ben at bwidawsk.net> wrote:
>>
>>> ---
>>>  include/GL/internal/dri_interface.h      | 27
>>> ++++++++++++++++++++++++++-
>>
>> Split the Infra from the i965 implementation ?
>>
>
> Sure. Doesn't matter to me.
>
Just a big thank you for the respin on the series - it looks great !

Small note in case people poke you that this "broke" their builds - if
make is fine while make install fails they're hitting a libtool
bug^Wfeature.
Workarounds include - moving the system libgbm, building in clean
chroot or using slibtool.

>>> @@ -840,6 +869,7 @@ static const __DRIimageExtension intelImageExtension
>>> = {
>>
>> Afaict, nothing in this series bumps the version to 14.
>> So you either missed a patch or we have a bug somewhere ?
>>
>
> Well, it bumps the version in dri_interface.h. Formerly, before splitting
> things
> up, this patch had the i965 version bumped too, but that's gone now. I'm
> happy
> to reword this however you'd like.
>
Since i965 does not fully implement the v14 you're correct in not
bumping the version in the i965 driver.

Note: the version in dri_interface.h is the one that drivers/loaders
can implement, not the one that they do.
Or in other words - no driver/loader should use the __DRI..._VERSION defines.

Thanks
Emil