[Mesa-dev] [PATCH 03/23] nir: Fix syntax.

Dylan Baker dylan at pnwbakers.com
Thu Mar 16 21:31:57 UTC 2017


Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Quoting Matt Turner (2017-03-16 14:18:00)
> et is not an abbreviation.
> ---
>  src/compiler/nir/nir_from_ssa.c          | 10 +++++-----
>  src/compiler/nir/nir_lower_vars_to_ssa.c |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_ssa.c
> index fdfbf98..d2646c6 100644
> --- a/src/compiler/nir/nir_from_ssa.c
> +++ b/src/compiler/nir/nir_from_ssa.c
> @@ -32,7 +32,7 @@
>  /*
>   * This file implements an out-of-SSA pass as described in "Revisiting
>   * Out-of-SSA Translation for Correctness, Code Quality, and Efficiency" by
> - * Boissinot et. al.
> + * Boissinot et al.
>   */
>  
>  struct from_ssa_state {
> @@ -64,9 +64,9 @@ ssa_def_dominates(nir_ssa_def *a, nir_ssa_def *b)
>  /* The following data structure, which I have named merge_set is a way of
>   * representing a set registers of non-interfering registers.  This is
>   * based on the concept of a "dominance forest" presented in "Fast Copy
> - * Coalescing and Live-Range Identification" by Budimlic et. al. but the
> + * Coalescing and Live-Range Identification" by Budimlic et al. but the
>   * implementation concept is taken from  "Revisiting Out-of-SSA Translation
> - * for Correctness, Code Quality, and Efficiency" by Boissinot et. al..
> + * for Correctness, Code Quality, and Efficiency" by Boissinot et al.
>   *
>   * Each SSA definition is associated with a merge_node and the association
>   * is represented by a combination of a hash table and the "def" parameter
> @@ -177,7 +177,7 @@ merge_merge_sets(merge_set *a, merge_set *b)
>   *
>   * This is an implementation of Algorithm 2 in "Revisiting Out-of-SSA
>   * Translation for Correctness, Code Quality, and Efficiency" by
> - * Boissinot et. al.
> + * Boissinot et al.
>   */
>  static bool
>  merge_sets_interfere(merge_set *a, merge_set *b)
> @@ -561,7 +561,7 @@ emit_copy(nir_builder *b, nir_src src, nir_src dest_src)
>  /* Resolves a single parallel copy operation into a sequence of movs
>   *
>   * This is based on Algorithm 1 from "Revisiting Out-of-SSA Translation for
> - * Correctness, Code Quality, and Efficiency" by Boissinot et. al..
> + * Correctness, Code Quality, and Efficiency" by Boissinot et al.
>   * However, I never got the algorithm to work as written, so this version
>   * is slightly modified.
>   *
> diff --git a/src/compiler/nir/nir_lower_vars_to_ssa.c b/src/compiler/nir/nir_lower_vars_to_ssa.c
> index 4ea5ea5..37a786c 100644
> --- a/src/compiler/nir/nir_lower_vars_to_ssa.c
> +++ b/src/compiler/nir/nir_lower_vars_to_ssa.c
> @@ -475,7 +475,7 @@ lower_copies_to_load_store(struct deref_node *node,
>   *
>   * This algorithm is very similar to the one outlined in "Efficiently
>   * Computing Static Single Assignment Form and the Control Dependence
> - * Graph" by Cytron et. al.  The primary difference is that we only put one
> + * Graph" by Cytron et al.  The primary difference is that we only put one
>   * SSA def on the stack per block.
>   */
>  static bool
> -- 
> 2.10.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170316/40abae8e/attachment.sig>


More information about the mesa-dev mailing list