[Mesa-dev] [PATCH v2 20/27] st/omx: add DRI3 support

Christian König christian.koenig at amd.com
Fri May 5 11:45:53 UTC 2017


Am 04.05.2017 um 18:33 schrieb Emil Velikov:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Cc: Christian König <christian.koenig at amd.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> UNTESTED.

Looks sane to me, but what bothers me a bit is that it is untested.

Leo do we (or QA) have a system somewhere where we could trow such 
things at and give them a try? Setting up a box for transcode testing is 
always quite a hassle.

Christian.

> ---
>   src/gallium/state_trackers/omx/entrypoint.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/omx/entrypoint.c b/src/gallium/state_trackers/omx/entrypoint.c
> index fa2074ad1b7..251cc7d65d5 100644
> --- a/src/gallium/state_trackers/omx/entrypoint.c
> +++ b/src/gallium/state_trackers/omx/entrypoint.c
> @@ -103,7 +103,9 @@ struct vl_screen *omx_get_screen(void)
>            if (!omx_display)
>               goto error;
>   
> -         omx_screen = vl_dri2_screen_create(omx_display, 0);
> +         omx_screen = vl_dri3_screen_create(omx_display, 0);
> +         if (!omx_screen)
> +            omx_screen = vl_dri2_screen_create(omx_display, 0);
>            if (!omx_screen) {
>               XCloseDisplay(omx_display);
>               goto error;




More information about the mesa-dev mailing list