[Mesa-dev] [PATCH v2 2/2] anv/i965: drop libdrm_intel dependency completely

[Emil Velikov]

On 5 May 2017 at 15:36, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Thu, May 04, 2017 at 12:19:22PM -0700, Lionel Landwerlin wrote:
>> With Ken's work to drop the library dependency on libdrm_intel, we now
>> only depend on libdrm_intel for the kernel uapi headers it provides.
>> It seems like we're better off just embeddeding those headers
>> ourselves, making the lives of people developing news features tightly
>> integrated with the kernel a tiny bit easier.
>>
>> v2: Just drop libdrm_intel, not libdrm (Lionel)
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>
> Header files need to be generated by the make headers_install target in
> the kernel, and then the resulting stuff imported (it lands in
> kernel-src/usr/include/drm/).
>
> Otherwise you end up with kernel #defines gunk in userspace, which sooner
> or later will clash with glibc and other fun. I also recommend you
> reference the exact kernel sha1 or release you've used to generate these.

In order to avoid repeating oneself it might be worth writing a
section like the following
https://cgit.freedesktop.org/mesa/drm/tree/include/drm/README#n68

Writing a pre-commit hook which checks for the above should also be doable.

-Emil