[Mesa-dev] [PATCH] mesa: fix KHR_no_error SSO support

Timothy Arceri tarceri at itsqueeze.com
Fri May 12 05:29:57 UTC 2017


Fixes: 00c5119a5e821 ("mesa: add KHR_no_error support for glUseProgramStages()")
---

 Found with the new no_error piglit profile [1]. Up until now my testing has been
 adhoc, selecting a few tests that take the new KHR_no_error path. Going forward
 testing should be more thorough once tests are enable in the new profile.

 [1] https://patchwork.freedesktop.org/series/24332/

  src/mesa/main/pipelineobj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/pipelineobj.c b/src/mesa/main/pipelineobj.c
index 67a8fc8..0d1d57c 100644
--- a/src/mesa/main/pipelineobj.c
+++ b/src/mesa/main/pipelineobj.c
@@ -258,21 +258,21 @@ void GLAPIENTRY
 _mesa_UseProgramStages_no_error(GLuint pipeline, GLbitfield stages,
                                 GLuint prog)
 {
    GET_CURRENT_CONTEXT(ctx);
 
    struct gl_pipeline_object *pipe =
       _mesa_lookup_pipeline_object(ctx, pipeline);
    struct gl_shader_program *shProg = NULL;
 
    if (prog)
-      _mesa_lookup_shader_program(ctx, prog);
+      shProg = _mesa_lookup_shader_program(ctx, prog);
 
    /* Object is created by any Pipeline call but glGenProgramPipelines,
     * glIsProgramPipeline and GetProgramPipelineInfoLog
     */
    pipe->EverBound = GL_TRUE;
 
    use_program_stages(ctx, shProg, stages, pipe);
 }
 
 /**
-- 
2.9.3



More information about the mesa-dev mailing list