[Mesa-dev] [PATCH] vulkan/wsi/wayland: Fix proxy wrappers for swapchain recreation

Daniel Stone daniel at fooishbar.org
Sat May 20 16:00:56 UTC 2017


Hi Philipp,

On 19 May 2017 at 23:07, Philipp Zabel <philipp.zabel at gmail.com> wrote:
> Before the swapchain event queue is destroyed, all proxy objects that reference
> it must be dropped. Otherwise we risk a use-after-free if a frame callback event
> or buffer release events are received afterwards.
> This happens when an application destroys and recreates a swapchain in FIFO
> mode between two frames without using the VkSwapchainCreateInfoKHR::oldSwapchain
> mechanism to keep the old swapchain until after the next redraw.

Thanks, this looks good to me - pushed now.

Cheers,
Daniel


More information about the mesa-dev mailing list