[Mesa-dev] [PATCH] docs: Fix GL_MESA_program_debug enums

[Roland Scheidegger]

Am 07.11.2017 um 11:42 schrieb Eric Engestrom:
> On Tuesday, 2017-11-07 01:44:49 +0100, sroland at vmware.com wrote:
>> From: Roland Scheidegger <sroland at vmware.com>
>>
>> 13b303ff9265b89bdd9100e32f905e9cdadfad81 added the actual enums but
>> didn't remove the already existing XXXX ones. (And also duplicated
>> the "fragment" names instead of using the "vertex" names.)
> 
> Fixes: 13b303ff9265b89bdd91 "docs: Update the list of used MESA GL enums."
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> 
>> ---
>>  docs/specs/enums.txt | 26 ++++++++------------------
>>  1 file changed, 8 insertions(+), 18 deletions(-)
>>
>> diff --git a/docs/specs/enums.txt b/docs/specs/enums.txt
>> index 4b0485f..7b5709b 100644
>> --- a/docs/specs/enums.txt
>> +++ b/docs/specs/enums.txt
>> @@ -46,14 +46,14 @@ GL_MESA_shader_debug.spec: (obsolete)
>>          GL_DEBUG_ASSERT_MESA             0x875B
>>  
>>  GL_MESA_program_debug: (obsolete)
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_MESA      0x????
>> -	GL_VERTEX_PROGRAM_CALLBACK_MESA        0x????
>> -	GL_FRAGMENT_PROGRAM_POSITION_MESA      0x????
>> -	GL_VERTEX_PROGRAM_POSITION_MESA        0x????
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_FUNC_MESA 0x????
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_DATA_MESA 0x????
>> -	GL_VERTEX_PROGRAM_CALLBACK_FUNC_MESA   0x????
>> -	GL_VERTEX_PROGRAM_CALLBACK_DATA_MESA   0x????
>> +	GL_FRAGMENT_PROGRAM_POSITION_MESA	0x8BB0
>> +	GL_FRAGMENT_PROGRAM_CALLBACK_MESA	0x8BB1
>> +	GL_FRAGMENT_PROGRAM_CALLBACK_FUNC_MESA	0x8BB2
>> +	GL_FRAGMENT_PROGRAM_CALLBACK_DATA_MESA	0x8BB3
>> +	GL_VERTEX_PROGRAM_POSITION_MESA		0x8BB4
>> +	GL_VERTEX_PROGRAM_CALLBACK_MESA		0x8BB5
>> +	GL_VERTEX_PROGRAM_CALLBACK_FUNC_MESA	0x8BB6
>> +	GL_VERTEX_PROGRAM_CALLBACK_DATA_MESA	0x8BB7
> 
> Nit: use spaces instead of tabs for alignment, so that it's also
> aligned for other people :)
Ok. The tabs weren't my invention, they are copy/paste.
It looks like this file has very inconsistent tabs/spaces usage, some
blocks use tabs, some spaces, some use both...

Roland


>>  
>>  GL_MESAX_texture_stack:
>>  	GL_TEXTURE_1D_STACK_MESAX            0x8759
>> @@ -63,16 +63,6 @@ GL_MESAX_texture_stack:
>>  	GL_TEXTURE_1D_STACK_BINDING_MESAX    0x875D
>>  	GL_TEXTURE_2D_STACK_BINDING_MESAX    0x875E
>>  
>> -GL_MESA_program_debug
>> -	GL_FRAGMENT_PROGRAM_POSITION_MESA	0x8BB0
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_MESA	0x8BB1
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_FUNC_MESA	0x8BB2
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_DATA_MESA	0x8BB3
>> -	GL_FRAGMENT_PROGRAM_POSITION_MESA	0x8BB4
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_MESA	0x8BB5
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_FUNC_MESA	0x8BB6
>> -	GL_FRAGMENT_PROGRAM_CALLBACK_DATA_MESA	0x8BB7
>> -
>>  GL_MESA_tile_raster_order
>>  	GL_TILE_RASTER_ORDER_FIXED_MESA		0x8BB8
>>  	GL_TILE_RASTER_ORDER_INCREASING_X_MESA	0x8BB9
>> -- 
>> 2.7.4
>>