[Mesa-dev] [Mesa-stable] [PATCH 02/14] anv/cmd_buffer: Take bo_offset into account in fast clear state addresses

Jason Ekstrand jason at jlekstrand.net
Tue Nov 21 00:00:32 UTC 2017


On Mon, Nov 20, 2017 at 3:51 PM, Andres Gomez <agomez at igalia.com> wrote:

> Jason, this nominated patch landed without mentioning any specific
> stable queue.
>
> Similarly to the 01/14, from what I'm seeing, it depends on
> a62a97933578 which didn't make it for 17.2 so I'm dropping it for that
> queue.
>
> Let me know what you think.
>

Looks correct to me.


> On Mon, 2017-11-13 at 08:12 -0800, Jason Ekstrand wrote:
> > Otherwise, if the image is not bound to the start of the buffer, we're
> > going to be reading and writing its fast clear state in the wrong spot.
> >
> > Cc: mesa-stable at lists.freedesktop.org
> > ---
> >  src/intel/vulkan/genX_cmd_buffer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> > index 2564976..9eb6074 100644
> > --- a/src/intel/vulkan/genX_cmd_buffer.c
> > +++ b/src/intel/vulkan/genX_cmd_buffer.c
> > @@ -461,7 +461,7 @@ get_fast_clear_state_address(const struct
> anv_device *device,
> >
> >     return (struct anv_address) {
> >        .bo = image->planes[plane].bo,
> > -      .offset = offset,
> > +      .offset = image->planes[plane].bo_offset + offset,
> >     };
> >  }
> >
> --
> Br,
>
> Andres
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171120/516644af/attachment.html>


More information about the mesa-dev mailing list