[Mesa-dev] NIR linking optimisations for Gallium drivers

[Dieter Nützel]

Hello Tim,

with both of your latest series I get this:

   CC       state_tracker/st_program.lo
state_tracker/st_program.c: In function ‘st_translate_geometry_program’:
state_tracker/st_program.c:1435:25: error: implicit declaration of 
function ‘st_glsl_to_nir’; did you mean ‘st_link_nir’? 
[-Werror=implicit-function-declaration]
        nir_shader *nir = st_glsl_to_nir(st, &stgp->Base, 
stgp->shader_program,
                          ^~~~~~~~~~~~~~
                          st_link_nir
state_tracker/st_program.c:1435:25: warning: initialization makes 
pointer from integer without a cast [-Wint-conversion]
cc1: some warnings being treated as errors
make[5]: *** [Makefile:2993: state_tracker/st_program.lo] Fehler 1

Greetings,
Dieter

Am 21.11.2017 04:37, schrieb Timothy Arceri:
> This series depends on:
> https://patchwork.freedesktop.org/series/34131/
> 
> Tested without regression on radeonsi.
> 
> Shader-db results (still limited to GLSL 1.40 so not to interesting):
> 
> Totals from affected shaders:
> SGPRS: 29440 -> 30464 (3.48 %)
> VGPRS: 19620 -> 19584 (-0.18 %)
> Spilled SGPRs: 131 -> 129 (-1.53 %)
> Spilled VGPRs: 0 -> 0 (0.00 %)
> Private memory VGPRs: 0 -> 0 (0.00 %)
> Scratch size: 0 -> 0 (0.00 %) dwords per thread
> Code Size: 749312 -> 749548 (0.03 %) bytes
> LDS: 0 -> 0 (0.00 %) blocks
> Max Waves: 4751 -> 4767 (0.34 %)
> Wait states: 0 -> 0 (0.00 %)
> 
> The middle patches just move things around so that we can make use
> of the linking opts, hopefully having them split up this much should
> make regression testing easy for the existing gallium nir drivers.
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev