[Mesa-dev] [PATCH 1/2] radv: check that pipeline is different before binding it

[Bas Nieuwenhuizen]

Series is

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Wed, Oct 4, 2017 at 10:27 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> We only need to dirty the descriptors when the pipeline is
> a new one, because user SGPRs can be potentially different.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 61ea11c12a..4b41b358e9 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -2454,14 +2454,20 @@ void radv_CmdBindPipeline(
>         RADV_FROM_HANDLE(radv_cmd_buffer, cmd_buffer, commandBuffer);
>         RADV_FROM_HANDLE(radv_pipeline, pipeline, _pipeline);
>
> -       radv_mark_descriptor_sets_dirty(cmd_buffer);
> -
>         switch (pipelineBindPoint) {
>         case VK_PIPELINE_BIND_POINT_COMPUTE:
> +               if (cmd_buffer->state.compute_pipeline == pipeline)
> +                       return;
> +               radv_mark_descriptor_sets_dirty(cmd_buffer);
> +
>                 cmd_buffer->state.compute_pipeline = pipeline;
>                 cmd_buffer->push_constant_stages |= VK_SHADER_STAGE_COMPUTE_BIT;
>                 break;
>         case VK_PIPELINE_BIND_POINT_GRAPHICS:
> +               if (cmd_buffer->state.pipeline == pipeline)
> +                       return;
> +               radv_mark_descriptor_sets_dirty(cmd_buffer);
> +
>                 cmd_buffer->state.pipeline = pipeline;
>                 if (!pipeline)
>                         break;
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev