[Mesa-dev] [PATCH] radv: Only set the MTYPE flags on GFX9+.

Dave Airlie airlied at gmail.com
Sun Oct 8 23:48:58 UTC 2017


Reviewed-by: Dave Airlie <airlied at redhat.com>

On 9 October 2017 at 05:58, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl> wrote:
> Older kernels fail the va_op with this flag set. If the kernel
> supports GFX9 usefully, it will also support this flag.
>
> Fixes: e8d57802fea "radv/gfx9: allocate events from uncached VA space"
> ---
>  src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c
> index d910aae4ba9..bffb76bb331 100644
> --- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c
> +++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c
> @@ -345,7 +345,7 @@ radv_amdgpu_winsys_bo_create(struct radeon_winsys *_ws,
>
>
>         uint32_t va_flags = 0;
> -       if (flags & RADEON_FLAG_VA_UNCACHED)
> +       if ((flags & RADEON_FLAG_VA_UNCACHED) && ws->info.chip_class >= GFX9)
>                 va_flags |= AMDGPU_VM_MTYPE_UC;
>         r = radv_amdgpu_bo_va_op(ws->dev, buf_handle, 0, size, va, va_flags, AMDGPU_VA_OP_MAP);
>         if (r)
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list