[Mesa-dev] [PATCH] radv: Do not read from the disk cache with RADV_DEBUG=nocache.

[Timothy Arceri]

On 16/10/17 22:54, Bas Nieuwenhuizen wrote:
> Otherwise the flag is borderline useless.

This disk cache util checks for MESA_GLSL_CACHE_DISABLE. Maybe we should 
make the name more generic and combine these flags? Doesn't seem like 
much use having two as you say.


> ---
>   src/amd/vulkan/radv_pipeline_cache.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline_cache.c
> index fc99b43fff0..458fe998b18 100644
> --- a/src/amd/vulkan/radv_pipeline_cache.c
> +++ b/src/amd/vulkan/radv_pipeline_cache.c
> @@ -167,7 +167,8 @@ radv_create_shader_variant_from_pipeline_cache(struct radv_device *device,
>   		entry = radv_pipeline_cache_search(device->mem_cache, sha1);
>   
>   	if (!entry) {
> -		if (!device->physical_device->disk_cache)
> +		if (!device->physical_device->disk_cache ||
> +		    (device->instance->debug_flags & RADV_DEBUG_NO_CACHE))
>   			return NULL;
>   		uint8_t disk_sha1[20];
>   		disk_cache_compute_key(device->physical_device->disk_cache,
>