[Mesa-dev] [PATCH] i965: Fix ARB_indirect_parameters logic.

[Kenneth Graunke]

On Thursday, October 26, 2017 4:24:10 AM PDT Manolova, Plamena wrote:
[snip]
> After taking another look you're absolutely right. For some reason
> propagating the predicates like this didn't occur to me.
> If we use this approach couldn't we get away with just having one predicate
> per draw call? Maybe something like this:
> 
>          unsigned combine_op = MI_PREDICATE_COMBINEOP_AND;
>          if (i == 0 && brw->predicate.state != BRW_PREDICATE_STATE_USE_BIT)
>             combine_op = MI_PREDICATE_COMBINEOP_SET;
> 
>          BEGIN_BATCH(1);
>          OUT_BATCH(GEN7_MI_PREDICATE |
>                    MI_PREDICATE_LOADOP_LOADINV | combine_op |
>                    MI_PREDICATE_COMPAREOP_SRCS_EQUAL);
>          ADVANCE_BATCH();
> 
> Then we can ditch the one using MI_PREDICATE_COMPAREOP_DELTAS_EQUAL?

Yep, I think that would work.  That's what I was trying to suggest on
IRC the other day, actually, I just didn't explain it very well. :)

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171026/802df9e5/attachment.sig>