[Mesa-dev] [PATCH 1/2] st/nine: do not double-close the fd on teardown

[Axel Davy]

Hi Emil,

This patch and the nine part of the second patch look fine.

Reviewed-by: Axel Davy <davyaxel0 at gmail.com>

for them.

Yours,

Axel

On 29/08/2018 19:13, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> As the newly introduced comment says:
>   The pipe loader takes ownership of the fd
>
> Thus, there's no need to close it again.
>
> Cc: Patrick Rudolph <siro at das-labor.org>
> Cc: Axel Davy <davyaxel0 at gmail.com>
> Cc: mesa-stable at lists.freedesktop.org>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>   src/gallium/targets/d3dadapter9/drm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/targets/d3dadapter9/drm.c b/src/gallium/targets/d3dadapter9/drm.c
> index 85b3e10633e..a2a36dbbda9 100644
> --- a/src/gallium/targets/d3dadapter9/drm.c
> +++ b/src/gallium/targets/d3dadapter9/drm.c
> @@ -107,7 +107,7 @@ drm_destroy( struct d3dadapter9_context *ctx )
>       if (drm->dev)
>           pipe_loader_release(&drm->dev, 1);
>   
> -    close(drm->fd);
> +    /* The pipe loader takes ownership of the fd */
>       FREE(ctx);
>   }
>