[Mesa-dev] [PATCH] radv: expose VK_EXT_scalar_block_layout

[Bas Nieuwenhuizen]

On Wed, Dec 5, 2018 at 2:14 PM Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
> Nothing to do, the compiler already handles that.
>
> All new dEQP.VK.ubo.* and dEQP.VK.ssbo.* pass, except some
> 16-bit tests that are quite related to fdo bug #108114.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_device.c      | 6 ++++++
>  src/amd/vulkan/radv_extensions.py | 1 +
>  2 files changed, 7 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index ad057a87509..d39e00eebe2 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -848,6 +848,12 @@ void radv_GetPhysicalDeviceFeatures2(
>                         features->geometryStreams = true;
>                         break;
>                 }
> +               case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SCALAR_BLOCK_LAYOUT_FEATURES_EXT: {
> +                       VkPhysicalDeviceScalarBlockLayoutFeaturesEXT *features =
> +                               (VkPhysicalDeviceScalarBlockLayoutFeaturesEXT *)ext;
> +                       features->scalarBlockLayout = true;

Last I talked to Nicolai, it looked like we may only be able to
support this on CI+.

> +                       break;
> +               }
>                 default:
>                         break;
>                 }
> diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_extensions.py
> index 6bdf988d117..7d726d6f5e8 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -107,6 +107,7 @@ EXTENSIONS = [
>      Extension('VK_EXT_global_priority',                   1, 'device->rad_info.has_ctx_priority'),
>      Extension('VK_EXT_pci_bus_info',                      1, True),
>      Extension('VK_EXT_sampler_filter_minmax',             1, 'device->rad_info.chip_class >= CIK'),
> +    Extension('VK_EXT_scalar_block_layout',               1, True),
>      Extension('VK_EXT_shader_viewport_index_layer',       1, True),
>      Extension('VK_EXT_shader_stencil_export',             1, True),
>      Extension('VK_EXT_transform_feedback',                1, True),
> --
> 2.19.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev