[Mesa-dev] [PATCH v3 3/9] meson: actually link with libomxil-bellagio

Dylan Baker dylan at pnwbakers.com
Thu Feb 8 23:30:47 UTC 2018


Quoting Dylan Baker (2018-02-08 15:23:23)
> Quoting Emil Velikov (2018-02-08 15:06:50)
> > On 2 February 2018 at 19:30, Dylan Baker <dylan at pnwbakers.com> wrote:
> > > This state tracker actually needs to link, unlike vdpau.
> > >
> > > Fixes: 1d36dc674d528b93b ("meson: build gallium omx state tracker")
> > > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> > > ---
> > >  meson.build | 5 -----
> > >  1 file changed, 5 deletions(-)
> > >
> > > diff --git a/meson.build b/meson.build
> > > index 4c6283c..2df2497 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -501,11 +501,6 @@ if with_gallium_omx
> > >      endif
> > >    endif
> > >  endif
> > > -if with_gallium_omx
> > > -  dep_omx = declare_dependency(
> > > -    compile_args : run_command(prog_pkgconfig, ['libomxil-bellagio', '--cflags']).stdout().split()
> > > -  )
> > > -endif
> > >
> > While looking at the existing code it seems that we don't check the
> > omx version number.
> > But that can happen as a follow-up patch at a later stage.
> > 
> > -Emil
> 
> You're right, I'll send a patch for that.
> 
> Dylan
> 

Oh, I know why meson doesn't check the version. The required version in autotools is 0.0

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180208/cf8375fc/attachment.sig>


More information about the mesa-dev mailing list