[Mesa-dev] [PATCH 4/9] intel/blorp: Simplify asserts in blorp_ccs_op

Jason Ekstrand jason at jlekstrand.net
Tue Feb 20 23:15:22 UTC 2018


If we use any invalid CCS ops for a particular platform, we will hit an
unreachable() in the blorp back-end.  The only on CCS op not supported
by this function at the moment is fast-clear.
---
 src/intel/blorp/blorp_clear.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
index c7c013a..2027fda 100644
--- a/src/intel/blorp/blorp_clear.c
+++ b/src/intel/blorp/blorp_clear.c
@@ -875,17 +875,7 @@ blorp_ccs_op(struct blorp_batch *batch,
    params.x1 = ALIGN(params.x1, x_scaledown) / x_scaledown;
    params.y1 = ALIGN(params.y1, y_scaledown) / y_scaledown;
 
-   if (batch->blorp->isl_dev->info->gen >= 10) {
-      assert(ccs_op == ISL_AUX_OP_FULL_RESOLVE ||
-             ccs_op == ISL_AUX_OP_PARTIAL_RESOLVE ||
-             ccs_op == ISL_AUX_OP_AMBIGUATE);
-   } else if (batch->blorp->isl_dev->info->gen >= 9) {
-      assert(ccs_op == ISL_AUX_OP_FULL_RESOLVE ||
-             ccs_op == ISL_AUX_OP_PARTIAL_RESOLVE);
-   } else {
-      /* Broadwell and earlier do not have a partial resolve */
-      assert(ccs_op == ISL_AUX_OP_FULL_RESOLVE);
-   }
+   assert(ccs_op != ISL_AUX_OP_FAST_CLEAR);
    params.fast_clear_op = ccs_op;
    params.num_layers = num_layers;
 
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list