[Mesa-dev] [PATCH] mesa: remove invalid assertion in _mesa_enable_vertex_array_attrib()

Roland Scheidegger sroland at vmware.com
Tue Jan 30 17:35:17 UTC 2018


Should the meta module not do this?
In any case,
Reviewed-by: Roland Scheidegger <sroland at vmware.com>

Am 30.01.2018 um 18:14 schrieb Brian Paul:
> The meta module passes some 0-based attrib values.  Should fix Piglit
> regressions reported by Mark Janes.
> 
> Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D104863&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=_QIjpv-UJ77xEQY8fIYoQtr5qv8wKrPJc7v7_-CYAb0&m=xOz2kY7Vkhso-In1VT-iEa8fb2AR83C9FQ3IW8KLXzU&s=YQYaKowlcOY50rg1E_q3wnoxzHPbNhIAO8UJd_t2EpM&e=
> ---
>  src/mesa/main/varray.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
> index b2783e2..bc0afa6 100644
> --- a/src/mesa/main/varray.c
> +++ b/src/mesa/main/varray.c
> @@ -1065,7 +1065,6 @@ _mesa_enable_vertex_array_attrib(struct gl_context *ctx,
>                                   struct gl_vertex_array_object *vao,
>                                   gl_vert_attrib attrib)
>  {
> -   assert(attrib >= VERT_ATTRIB_GENERIC0);
>     assert(attrib < ARRAY_SIZE(vao->VertexAttrib));
>  
>     if (!vao->VertexAttrib[attrib].Enabled) {
> 



More information about the mesa-dev mailing list