[Mesa-dev] [PATCH mesa v2] vulkan/wsi: fix assignment in assert()

Lionel Landwerlin lionel.g.landwerlin at intel.com
Thu Jul 26 09:10:10 UTC 2018


On 25/07/18 20:03, Eric Engestrom wrote:
> CovID: 1438113, 1438118, 1438119, 1438121
> Fixes: dc1d10b396179766227df "anv,radv: Add support for VK_KHR_get_display_properties2"
> Cc: Jason Ekstrand <jason.ekstrand at intel.com>
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

> ---
>   src/vulkan/wsi/wsi_common_display.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/vulkan/wsi/wsi_common_display.c b/src/vulkan/wsi/wsi_common_display.c
> index ac932d4368a0293fe97e..e6cba188dfaf8d790415 100644
> --- a/src/vulkan/wsi/wsi_common_display.c
> +++ b/src/vulkan/wsi/wsi_common_display.c
> @@ -619,7 +619,7 @@ wsi_display_fill_in_display_mode_properties(
>      struct wsi_display_mode *display_mode,
>      VkDisplayModeProperties2KHR *properties)
>   {
> -   assert(properties->sType = VK_STRUCTURE_TYPE_DISPLAY_MODE_PROPERTIES_2_KHR);
> +   assert(properties->sType == VK_STRUCTURE_TYPE_DISPLAY_MODE_PROPERTIES_2_KHR);
>      VkDisplayModePropertiesKHR *prop = &properties->displayModeProperties;
>   
>      prop->displayMode = wsi_display_mode_to_handle(display_mode);
> @@ -763,7 +763,7 @@ wsi_get_display_plane_capabilities2(
>      const VkDisplayPlaneInfo2KHR *pDisplayPlaneInfo,
>      VkDisplayPlaneCapabilities2KHR *capabilities)
>   {
> -   assert(capabilities->sType =
> +   assert(capabilities->sType ==
>             VK_STRUCTURE_TYPE_DISPLAY_PLANE_CAPABILITIES_2_KHR);
>   
>      return wsi_get_display_plane_capabilities(physical_device, wsi_device,




More information about the mesa-dev mailing list