[Mesa-dev] [PATCH 4/4] meson: remove a bunch of out of date TODO's

Dylan Baker dylan at pnwbakers.com
Mon Jun 11 16:31:44 UTC 2018


Quoting Eric Anholt (2018-06-08 11:29:41)
> Dylan Baker <dylan at pnwbakers.com> writes:
> 
> > [ Unknown signature status ]
> > Quoting Eric Anholt (2018-06-07 14:29:19)
> >> Dylan Baker <dylan at pnwbakers.com> writes:
> >> 
> >> > Some of these are done already, some of them are things we're not going
> >> > to do, like have a toggle for GLX_TLS.
> >> >
> >> > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> >> 
> >> > -
> >> >  if with_osmesa != 'none'
> >> >    if with_osmesa == 'classic' and not with_dri_swrast
> >> >      error('OSMesa classic requires dri (classic) swrast.')
> >> > @@ -1240,8 +1235,6 @@ if with_osmesa != 'none'
> >> >    endif
> >> >  endif
> >> >  
> >> > -# TODO: symbol mangling
> >> 
> >> I don't see -DUSE_MGL_NAMESPACE in meson.builds
> >> 
> >> Other than that, r-b.
> >
> > The only place that's used is in conjunction with created MangledGL.so. IS that
> > a useful configuration anymore?
> 
> VTK used to use it, but it looks like that's out of date.  Let's either
> GC the USE_MGL_NAMESPACE code or leave the todo in for meson until it's
> supported, though.

Okay, I'll leave the TODO for now and see about nuking USE_MGL_NAMESPACE as a
feature.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180611/9489740b/attachment.sig>


More information about the mesa-dev mailing list