[Mesa-dev] [PATCH 2/3] nv50, nvc0: Support BGRX1010102 and RGBX1010102 for sampling.

Ilia Mirkin imirkin at alum.mit.edu
Mon Mar 12 20:49:39 UTC 2018


Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

It should be possible to get rendering on them BTW, with a bit of
state fixups for DST_ALPHA blending. Just haven't gotten around to it.

On Mon, Mar 12, 2018 at 4:45 PM, Mario Kleiner
<mario.kleiner.de at gmail.com> wrote:
> Add them as usable for textures, so they can be used by
> Wayland drm in 10 bpc mode and for X11 compositing under
> GLX and EGL. We need these formats to be supported at
> least for sampling, otherwise GLX_texture_from_pixmap
> and the equivalent EGL image extension won't work with
> X11 drawables of depth 30 and just display an all black
> window.
>
> Do not expose these formats as renderable, and thereby
> not as a fbconfig/EGLConfig/Visual, as NVidia hw does
> not support 10 bpc unorm formats without alpha channel.
>
> Tested under X11 + GLX/EGL + DRI2/DRI3 for compositing,
> and under Wayland+Weston drm backend with a Tesla and
> Pascal gpu.
>
> Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com>
> ---
>  src/gallium/drivers/nouveau/nv50/nv50_formats.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_formats.c b/src/gallium/drivers/nouveau/nv50/nv50_formats.c
> index fc5deac..0ead8ac 100644
> --- a/src/gallium/drivers/nouveau/nv50/nv50_formats.c
> +++ b/src/gallium/drivers/nouveau/nv50/nv50_formats.c
> @@ -153,7 +153,9 @@ const struct nv50_format nv50_format_table[PIPE_FORMAT_COUNT] =
>     F3(A, R9G9B9E5_FLOAT, NONE, R, G, B, xx, FLOAT, E5B9G9R9_SHAREDEXP, T),
>
>     C4(A, R10G10B10A2_UNORM, RGB10_A2_UNORM, R, G, B, A, UNORM, A2B10G10R10, TD),
> +   F3(A, R10G10B10X2_UNORM, RGB10_A2_UNORM, R, G, B, xx, UNORM, A2B10G10R10, T),
>     C4(A, B10G10R10A2_UNORM, BGR10_A2_UNORM, B, G, R, A, UNORM, A2B10G10R10, IB),
> +   F3(A, B10G10R10X2_UNORM, BGR10_A2_UNORM, B, G, R, xx, UNORM, A2B10G10R10, T),
>     C4(A, R10G10B10A2_SNORM, NONE, R, G, B, A, SNORM, A2B10G10R10, T),
>     C4(A, B10G10R10A2_SNORM, NONE, B, G, R, A, SNORM, A2B10G10R10, T),
>     C4(A, R10G10B10A2_UINT, RGB10_A2_UINT, R, G, B, A, UINT, A2B10G10R10, TR),
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list