[Mesa-dev] [PATCH] vbo: Use alloca for _vbo_draw_indirect.

Mathias Fröhlich Mathias.Froehlich at gmx.net
Fri Mar 30 15:42:08 UTC 2018


Hi Brian,

> Can you just rename 'space' to 'prim' and rm the prim = space assignment 
> below?
> 
> Also, could you put a comment on this function to explain the draw_count 
> and space/prim parameters, at least?
I'll try my best!

> Other than that, the series looks good.
> 
> Reviewed-by: Brian Paul <brianp at vmware.com>
Thanks for the review!!!

> Sorry for the slow review, busy with other things.
No worries. I can make use of the wait time in between :-)
But now, today is mesa time for me ...
Thank you!

best

Mathias




More information about the mesa-dev mailing list