[Mesa-dev] [PATCH 10/12] llvmpipe: remove pre LLVM 5.0 codepath

Jose Fonseca jfonseca at vmware.com
Thu Nov 1 10:08:12 UTC 2018


On 31/10/2018 13:30, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> LLVM versions earlier than 5.0.1 are no longer supported.
> 
> Cc: Roland Scheidegger <sroland at vmware.com>
> Cc: Jose Fonseca <jfonseca at vmware.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>   src/gallium/drivers/llvmpipe/lp_jit.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_jit.c b/src/gallium/drivers/llvmpipe/lp_jit.c
> index e2309f47157..ae5b0fe8151 100644
> --- a/src/gallium/drivers/llvmpipe/lp_jit.c
> +++ b/src/gallium/drivers/llvmpipe/lp_jit.c
> @@ -223,13 +223,9 @@ lp_jit_create_types(struct lp_fragment_shader_variant *lp)
>      }
>   
>      if (gallivm_debug & GALLIVM_DEBUG_IR) {
> -#if HAVE_LLVM >= 0x304
>         char *str = LLVMPrintModuleToString(gallivm->module);
>         fprintf(stderr, "%s", str);
>         LLVMDisposeMessage(str);
> -#else
> -      LLVMDumpModule(gallivm->module);
> -#endif
>      }
>   }
>   
> 

This and patch 3 looks good too.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>


More information about the mesa-dev mailing list