[Mesa-dev] [PATCH 1/4] bin/get-pick-list.sh: simplify git oneline printing

Eric Engestrom eric.engestrom at intel.com
Wed Nov 7 13:32:06 UTC 2018


On Wednesday, 2018-11-07 12:07:15 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Currently we force disable the pager via "|cat" where --no-pager
> exists. Additionally we could use git show instead of git log -n1.
> 
> Use those for a slightly more understandable code.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

> ---
>  bin/get-pick-list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> index 9e9a39e494b..ba741cc4114 100755
> --- a/bin/get-pick-list.sh
> +++ b/bin/get-pick-list.sh
> @@ -32,7 +32,7 @@ do
>  		continue
>  	fi
>  
> -	git log -n1 --pretty=oneline $sha | cat
> +	git --no-pager show --summary --oneline $sha
>  done
>  
>  rm -f already_picked
> -- 
> 2.19.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list