[Mesa-dev] [PATCH] i965: Fix -Wswitch on INTEL_COPY_STREAMING_LOAD

[Eric Engestrom]

On Thursday, 2018-11-08 12:55:35 -0800, Chad Versace wrote:
> The warning is emitted when building without INLINE_SSE41.

I sent https://patchwork.freedesktop.org/patch/259015/ a couple of
weeks ago, but your patch gives a more specific error message, so:
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

> ---
>  src/mesa/drivers/dri/i965/intel_tiled_memcpy.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c
> index 836f83d4a43..f9cc020d338 100644
> --- a/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c
> +++ b/src/mesa/drivers/dri/i965/intel_tiled_memcpy.c
> @@ -599,9 +599,11 @@ choose_copy_function(mem_copy_fn_type copy_type)
>        return memcpy;
>     case INTEL_COPY_RGBA8:
>        return rgba8_copy;
> -#if defined(INLINE_SSE41)
>     case INTEL_COPY_STREAMING_LOAD:
> +#if defined(INLINE_SSE41)
>        return _memcpy_streaming_load;
> +#else
> +      unreachable("INTEL_COPY_STREAMING_LOAD requires sse4.1");
>  #endif
>     case INTEL_COPY_INVALID:
>        unreachable("invalid copy_type");
> -- 
> 2.19.1.930.g4563a0d9d0-goog
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev