[Mesa-dev] [PATCH 01/31] nir/validate: Print when the validation failed

[Jason Ekstrand]

On Mon, Oct 22, 2018 at 6:16 PM Eric Anholt <eric at anholt.net> wrote:

> Jason Ekstrand <jason at jlekstrand.net> writes:
>
> > diff --git a/src/mesa/drivers/dri/i965/brw_program.c
> b/src/mesa/drivers/dri/i965/brw_program.c
> > index f5ebd3c3b05..78050cda359 100644
> > --- a/src/mesa/drivers/dri/i965/brw_program.c
> > +++ b/src/mesa/drivers/dri/i965/brw_program.c
> > @@ -91,14 +91,14 @@ brw_create_nir(struct brw_context *brw,
> >
> >        nir_remove_dead_variables(nir, nir_var_shader_in |
> nir_var_shader_out);
> >        nir_lower_returns(nir);
> > -      nir_validate_shader(nir);
> > +      nir_validate_shader(nir, NULL);
> >        NIR_PASS_V(nir, nir_lower_io_to_temporaries,
> >                   nir_shader_get_entrypoint(nir), true, false);
> >     } else {
> >        nir = prog_to_nir(prog, options);
> >        NIR_PASS_V(nir, nir_lower_regs_to_ssa); /* turn registers into
> SSA */
> >     }
> > -   nir_validate_shader(nir);
> > +   nir_validate_shader(nir, NULL);
>
> It seems like you ought to have valid where args here.  Other than that,
> patch 1-5 are:
>

Yeah, I was lazy.  I added something.


> Reviewed-by: Eric Anholt <eric at anholt.net>
>

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181022/3000f63b/attachment-0001.html>