[Mesa-dev] [Bug 107547] shader crashing glsl_compiler (uniform block assigned to vec2, then component substraced by 1)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107547

Timothy Arceri <t_arceri at yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from Timothy Arceri <t_arceri at yahoo.com.au> ---
Should be fixed by:

commit 6f3c7374b11299c21d829db794fad3b756af60fb
Author: Danylo Piliaiev <danylo.piliaiev at gmail.com>
Date:   Wed Aug 15 15:46:22 2018 +0300

Date:   Wed Aug 15 15:46:22 2018 +0300

    glsl: Avoid propagating incompatible type of initializer

    do_assignment validated assigment but when rhs type was not compatible
    it proceeded without issues and returned error_emitted = false.
    On the other hand process_initializer expected do_assignment to always
    return compatible type and never fail.

    As a result when variable was initialized with incompatible type
    the type of variable changed to the incompatible one.
    This manifested in unnecessary error messages and in one case in crash.

    Example GLSL:
     vec4 tmp = vec2(0.0);
     tmp.z -= 1.0;

    Past error messages:
     initializer of type vec2 cannot be assigned to variable of type vec4
     invalid swizzle / mask `z'
     type mismatch
     operands to arithmetic operators must be numeric

    After this patch:
     initializer of type vec2 cannot be assigned to variable of type vec4

    In the other case when we initialize variable with incompatible struct,
    accessing variable's field leaded to a crash. Example:
     uniform struct {float field;} data;
     ...
     vec4 tmp = data;
     tmp.x -= 1.0;

    After the patch there is only error line without a crash:
     initializer of type #anon_struct cannot be assigned to variable of
      type vec4

    Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
    Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107547

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180919/5cce303b/attachment-0001.html>