[Mesa-dev] [PATCH] get_reviewer.pl: improve portability

Alyssa Ross hi at alyssa.is
Fri Apr 19 18:14:37 UTC 2019


Not all package managers / users will install perl into /usr/bin,
but /usr/bin/env /should/ always be present.

Using /usr/bin/env means that we can't give the -w argument to Perl,
so I added `use warnings' in the script.

Cc: Rob Clark <robclark at freedesktop.org>
---
 scripts/get_reviewer.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/get_reviewer.pl b/scripts/get_reviewer.pl
index 62deb922800..1677495ad6d 100755
--- a/scripts/get_reviewer.pl
+++ b/scripts/get_reviewer.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 # (c) 2007, Joe Perches <joe at perches.com>
 #           created from checkpatch.pl
 #
@@ -14,6 +14,7 @@
 # Licensed under the terms of the GNU GPL License version 2

 use strict;
+use warnings;

 my $P = $0;
 my $V = '0.26';
--
2.19.2



More information about the mesa-dev mailing list