[Mesa-dev] [PATCH] nir/lower_clip_cull: Fix an incorrect assert

Kenneth Graunke kenneth at whitecape.org
Thu Feb 21 18:20:32 UTC 2019


On Thursday, February 21, 2019 8:55:31 AM PST Jason Ekstrand wrote:
> Copy+paste error.  It was supposed to test cull and not clip.
> 
> Fixes: 4e69fba534e "nir: Rewrite lower_clip_cull_distance_arrays..."
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109717
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/compiler/nir/nir_lower_clip_cull_distance_arrays.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c b/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c
> index d98ffa69596..70578d6f3fd 100644
> --- a/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c
> +++ b/src/compiler/nir/nir_lower_clip_cull_distance_arrays.c
> @@ -101,7 +101,7 @@ combine_clip_cull(nir_shader *nir,
>     }
>  
>     if (cull) {
> -      assert(clip->data.compact);
> +      assert(cull->data.compact);
>        cull->data.how_declared = nir_var_hidden;
>        cull->data.location = VARYING_SLOT_CLIP_DIST0 + clip_array_size / 4;
>        cull->data.location_frac = clip_array_size % 4;
> 

Whoops.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190221/ef355de3/attachment-0001.sig>


More information about the mesa-dev mailing list