[Mesa-dev] [PATCH] spirv: OpImageQueryLod requires a sampler

[Samuel Iglesias Gonsálvez]

Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

On Wed, 2019-02-27 at 00:15 -0600, Jason Ekstrand wrote:
> No idea how this fell through the cracks besides the fact that the
> sampler bound at 0 almost always works and the CTS isn't amazing.  In
> any case, this appears to have been broken for almost forever.
> 
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/compiler/spirv/spirv_to_nir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/spirv/spirv_to_nir.c
> b/src/compiler/spirv/spirv_to_nir.c
> index f5511587be8..de5e6cc8659 100644
> --- a/src/compiler/spirv/spirv_to_nir.c
> +++ b/src/compiler/spirv/spirv_to_nir.c
> @@ -2154,6 +2154,7 @@ vtn_handle_texture(struct vtn_builder *b, SpvOp
> opcode,
>     case nir_texop_txl:
>     case nir_texop_txd:
>     case nir_texop_tg4:
> +   case nir_texop_lod:
>        /* These operations require a sampler */
>        p->src = nir_src_for_ssa(&sampler->dest.ssa);
>        p->src_type = nir_tex_src_sampler_deref;
> @@ -2162,7 +2163,6 @@ vtn_handle_texture(struct vtn_builder *b, SpvOp
> opcode,
>     case nir_texop_txf:
>     case nir_texop_txf_ms:
>     case nir_texop_txs:
> -   case nir_texop_lod:
>     case nir_texop_query_levels:
>     case nir_texop_texture_samples:
>     case nir_texop_samples_identical:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20190227/6a646d34/attachment.sig>