[Mesa-dev] [PATCH] vc4: Declare the last cpu pointer as being modified in NEON asm.

Emil Velikov emil.l.velikov at gmail.com
Tue Jan 29 17:25:17 UTC 2019


From: Emil Velikov <emil.velikov at collabora.com>

Earlier commit addressed 7 of the 8 instances available.

Cc: Carsten Haitzler (Rasterman) <raster at rasterman.com>
Cc: Eric Anholt <eric at anholt.net>
Fixes: 300d3ae8b14 ("vc4: Declare the cpu pointers as being modified in NEON asm.")
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
Gents my ARM assembly is limited so a confirmation or review would be
greatly appreciated.
---
 src/gallium/drivers/vc4/vc4_tiling_lt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/gallium/drivers/vc4/vc4_tiling_lt.c b/src/gallium/drivers/vc4/vc4_tiling_lt.c
index b9185c7fd1c..167161fdff5 100644
--- a/src/gallium/drivers/vc4/vc4_tiling_lt.c
+++ b/src/gallium/drivers/vc4/vc4_tiling_lt.c
@@ -194,9 +194,8 @@ vc4_store_utile(void *gpu, void *cpu, uint32_t cpu_stride, uint32_t cpp)
                          * d0-d7.
                          */
                         "vstm %[gpu], {q0, q1, q2, q3}\n"
-                        :
+                        : [cpu]         "+r"(cpu)
                         : [gpu]         "r"(gpu),
-                          [cpu]         "r"(cpu),
                           [cpu_stride]  "r"(cpu_stride)
                         : "q0", "q1", "q2", "q3");
         } else {
-- 
2.19.1



More information about the mesa-dev mailing list