[Mesa-dev] [PATCH 00/19] radv: some render pass related changes/cleanups

[Samuel Pitoiset]

Hi,

My plan is to rework transitions a bit and improve them. Like initializing
all undefined layouts in one shot instead of syncing inbetween. Also,
some subpass clears can be merged when the driver already initializes
metadata, and probably more.

This series is just a first step that cleanups stuff here and there.

Please review,
Thanks!

Samuel Pitoiset (19):
  radv: bail out when no image transitions will be performed
  radv: remove unused radv_render_pass_attachment::view_mask
  radv: remove useless MAYBE_UNUSED in CmdBeginRenderPass()
  radv: add radv_cmd_buffer_begin_subpass() helper
  radv: move subpass image transitions to
    radv_cmd_buffer_begin_subpass()
  radv: store the list of attachments for every subpass
  radv: use the new attachments array when starting subpasses
  radv: determine the last subpass id for every attachments
  radv: use the new attachments array in CmdEndRenderPass()
  radv: add radv_cmd_buffer_end_subpass() helper
  radv: move some render pass things to radv_render_pass_compile()
  radv: add radv_render_pass_add_subpass_dep() helper
  radv: track if subpasses have color attachments
  radv: handle subpass dependencies correctly
  radv: accumulate all ingoing external dependencies to the first
    subpass
  radv: execute external subpass barriers after ending subpasses
  radv: drop useless checks when resolving subpass color attachments
  radv: do not set preserveAttachments for internal render passes
  radv: don't flush src stages when dstStageMask == BOTTOM_OF_PIPE

 src/amd/vulkan/radv_cmd_buffer.c      | 148 ++++++++++------
 src/amd/vulkan/radv_meta_blit.c       |  12 +-
 src/amd/vulkan/radv_meta_blit2d.c     |  12 +-
 src/amd/vulkan/radv_meta_clear.c      |  54 +++---
 src/amd/vulkan/radv_meta_resolve.c    |  13 +-
 src/amd/vulkan/radv_meta_resolve_fs.c |  11 +-
 src/amd/vulkan/radv_pass.c            | 245 ++++++++++++++++----------
 src/amd/vulkan/radv_pipeline.c        |  25 +--
 src/amd/vulkan/radv_private.h         |  15 +-
 9 files changed, 316 insertions(+), 219 deletions(-)

-- 
2.20.1